libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [SCM] GNU Libtool branch, master, updated. v2.4.2-141-g4099c12


From: Eric Blake
Subject: Re: [SCM] GNU Libtool branch, master, updated. v2.4.2-141-g4099c12
Date: Mon, 19 Dec 2011 06:44:44 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 12/17/2011 10:22 PM, Gary V. Vaughan wrote:
>     libtool: minimise forks per invocation under bash.
>     
>     * build-aux/general.m4sh (lt_HAVE_PLUSEQ_OP, lt_HAVE_ARITH_OP)
>     (lt_HAVE_XSI_OPS): Set these without forking a test script when
>     running under bash, to avoid a few unnecessary forks.
>     

> +# We should try to minimise forks, especially on Windows where they are
> +# unreasonably slow, so skip the feature probes when bash is being used:
> +if test set = "${BASH_VERSION+set}"; then
> +    : ${lt_HAVE_ARITH_OP="yes"}
> +    : ${lt_HAVE_XSI_OPS="yes"}
> +    # The += operator was introduced in bash 3.1
> +    test -z "$lt_HAVE_PLUSEQ_OP" \
> +      && test 3000 -lt "$((${BASH_VERSINFO[0]}*1000 + ${BASH_VERSINFO[1]}))" 
> \

This MUST be hidden behind an eval.  Otherwise, shells like Solaris
/bin/sh will choke on trying to parse this line:

$ /bin/sh -c 'echo "$((${BASH_VERSINFO[0]}*1000 + \
    ${BASH_VERSINFO[1]}))"'
/bin/sh: bad substitution

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]