Re: [PATCH 02/10] tests: migrate legacy tests/demo tests to Autotest.

[Stefano Lattarini]

Only a quick incomplete review ...

On Friday 25 November 2011, Gary V wrote:
> +{
> +    test -n "$objdir" || exit 1
> +    $lt_INSTALL -d "$objdir/temp/libs"
> +    cp -f libhello.la "$objdir/temp"
> +    cp -f "$objdir"/libhello.* "$objdir/lt-hell$EXEEXT" "$objdir/temp/libs"
> +    trap "func_restore_files" 0 1 2 13 15
>
Quoting autoconf manual:

  With AIX sh, a trap on 0 installed in a shell function triggers at function
  exit rather than at script.

(I see this is code has only been moved by your patch, so you might want to
fix it in a follow-up?)

> +
> +/* At some point, cygwin will stop defining __CYGWIN32__, but b19 and
> + * earlier do not define __CYGWIN__.  This snippit allows us to check
>
s/snippit/snippet/ (I see this is code has only been moved by your patch,
so you might want to fix it in a follow-up?)


> + * for __CYGWIN__ reliably for both current, old, and (probable) future
> + * releases.
> + */

Regards,
  Stefano