[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check. |
|
Date: |
Tue, 15 Nov 2011 10:03:58 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 11/15/2011 09:49 AM, Charles Wilson wrote:
> On 11/15/2011 7:53 AM, Gary V. Vaughan wrote:
> tests/mdemo/Makefile.am
>> -## use @LIBLTDL@ because some broken makes do not accept macros in targets
>> +## use $(LIBLTDL) because some broken makes do not accept macros in targets
>
> This comment now makes zero sense. If you are now forcing the following
> rule:
>
> +$(LIBLTDL): $(top_distdir)/libtool \
>
> then (a) remove the comment completely, and (b) document somewhere that
> we now require non-broken make which DOES allow $(macros) in targets.
As an alternative, revert this change, and instead add a setting of
_makefile_at_at_check_exceptions in cfg.mk that exempts just @address@hidden
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value., (continued)
[PATCH 06/25] syntax-check: fix violations and re-enable sc_file_system., Gary V. Vaughan, 2011/11/15
[PATCH 07/25] syntax-check: fix violations and re-enable sc_m4_quote_check., Gary V. Vaughan, 2011/11/15
[PATCH 08/25] syntax-check: fix violations and re-enable sc_makefile_TAB_only_indentation., Gary V. Vaughan, 2011/11/15
[PATCH 10/25] syntax-check: fix violations and re-enable sc_prohibit_cvs_keyword., Gary V. Vaughan, 2011/11/15
[PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check., Gary V. Vaughan, 2011/11/15
- Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check., Charles Wilson, 2011/11/15
- Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check.,
Eric Blake <=
- Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check., Gary V. Vaughan, 2011/11/15
- Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check., Eric Blake, 2011/11/16
- Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check., Stefano Lattarini, 2011/11/16
- Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check., Gary V. Vaughan, 2011/11/16
- Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check., Eric Blake, 2011/11/16
- Re: [PATCH 09/25] syntax-check: fix violations and re-enable sc_makefile_at_at_check., Gary V. Vaughan, 2011/11/16
[PATCH 11/25] syntax-check: fix violations and re-enable sc_prohibit_doubled_word., Gary V. Vaughan, 2011/11/15
[PATCH 12/25] syntax-check: fix violations and re-enable sc_prohibit_empty_lines_at_EOF., Gary V. Vaughan, 2011/11/15
[PATCH 13/25] syntax-check: fix violations and re-enable sc_prohibit_have_config_h., Gary V. Vaughan, 2011/11/15
[PATCH 14/25] syntax-check: fix violations and re-enable sc_prohibit_magic_number_exit., Gary V. Vaughan, 2011/11/15