Re: [PATCH 04/25] syntax-check: fix violations and re-enable sc_cast_of_x_alloc_return_value.

[Charles Wilson]

On 11/15/2011 11:36 AM, Charles Wilson wrote:
> On 11/15/2011 7:53 AM, Gary V. Vaughan wrote:
>> * cfg.mk (local-checks-to-fix): Remove
>> sc_cast_of_x_alloc_return_value from list of disabled checks.
>> * libltdl/config/ltmain.m4sh (XMALLOC, XFREE): Unroll into their
>> xmalloc and free expansions so that this syntax-check can find
>> violations, and then fix them.
>> * iibltdl/libltdl/lt__alloc.h (MALLOC, REALLOC): Renamed to
>> xmalloc and xrealloc so that this syntax-check can find
>> violations.  Adjust all callers.
>> (FREE, MEMREASSIGN): Removed.  All callers unrolled into their
>> former expansions, and violations of this syntax-check fixed.
>> * libltdl/loaders/loadlibrary.c (LOCALFREE): Unrolled for
>> consistency.
> 
> Why do I get the feeling that the next time I try to build any .exe on
> cygwin/mingw with -Wall -Werror, I'm going to fail because all these
> (now removed) casts in the cwrapper source code were there specifically
> to suppress warnings...

And speaking of casts and C/C++...suppose you have package "foo" and you
want to build "foo" with CC=g++ -- that ought to be legal, right?

        <pathto>/foo-src/configure --prefix=... CC=g++

But that means on cygwin/mingw, if foo uses libtool then the cwrapper
will be built using ${CC} -- that is, g++.  Bang; you're dead -- because
the cast is required with C++, isn't it? (IIRC it's not just a warning,
it's an error, if the cast is missing).

--
Chuck