libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [SCM] GNU Libtool branch, master, updated. v2.4-58-g789817d


From: Bob Friesenhahn
Subject: Re: [SCM] GNU Libtool branch, master, updated. v2.4-58-g789817d
Date: Mon, 17 Oct 2011 08:52:58 -0500 (CDT)
User-agent: Alpine 2.01 (GSO 1266 2009-07-14)

On Mon, 17 Oct 2011, Gary V. Vaughan wrote:

          case $version_type in
+          # correct linux to gnu/linux during the next big refactor

You're not following the whitespace convention of the surrounding code.

Good point.  That's what comes of writing an emacs macro to do the edits
I suppose.  I'll fix and commit, thanks.

I think that it is best to include this sort of comment in the libtool TODO file similar to other tasks which are left to do rather than spamming the script with duplicated comments. Certainly no more than one comment near the point of first usage should be warranted if the comment must appear in the script.

Bob
--
Bob Friesenhahn
address@hidden, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]