libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

ping: [PATCH libtool] hardcoded path to dependent shared libraries on 32


From: John David Anglin
Subject: ping: [PATCH libtool] hardcoded path to dependent shared libraries on 32-bit hpux (libquadmath)
Date: Sun, 19 Dec 2010 11:04:36 -0500
User-agent: Mutt/1.5.16 (2007-06-09)

Ping.

On Fri, 10 Dec 2010, John David Anglin wrote:

> On Sun, 28 Nov 2010, Ralf Wildenhues wrote:
> 
> > * John David Anglin wrote on Sun, Nov 28, 2010 at 09:42:43PM CET:
> > > The current relative path to libquadmath can be incorrectly interpreted
> > > on systems that hard code library paths.  In particular, on 32-bit
> > > hppa*-*hpux*, the '..' part of the path is relative to the final 
> > > executable.
> > > As a result, all libgfortran tests fail due to a dynamic loader error.
> > > 
> > > The patch changes the path to an absolute path.
> > > 
> > > Tested on hppa2.0w-hp-hpux11.11 and i686-apple-darwin9 with no observed
> > > regressions.
> > > 
> > > OK for trunk?
> > 
> > That doesn't seem to make sense to me.  The fix should be in ltmain.sh
> > or in libtool.m4.  Please post the output of how libquadmath is linked
> > on your system (the 'libtool --mode=link' command plus all of its
> > output).
> 
> The attached change to ltmain.sh fixes the above problem on on 32-bit
> hppa*-*hpux*.  Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11.
> 
> Would you please apply if ok to libtool, gcc and sourceware?
> 
> Thanks,
> Dave
> -- 
> J. David Anglin                                  address@hidden
> National Research Council of Canada              (613) 990-0752 (FAX: 
> 952-6602)
> 
> 2010-12-10  John David Anglin  <address@hidden>
> 
>       * ltmain.sh (relink): Use absolute path when hardcoding with -L.
> 
> Index: ltmain.sh
> ===================================================================
> --- ltmain.sh (revision 167668)
> +++ ltmain.sh (working copy)
> @@ -5928,7 +5928,7 @@
>                test "$hardcode_direct_absolute" = no; then
>               add="$dir/$linklib"
>             elif test "$hardcode_minus_L" = yes; then
> -             add_dir="-L$dir"
> +             add_dir="-L$absdir"
>               # Try looking first in the location we're being installed to.
>               if test -n "$inst_prefix_dir"; then
>                 case $libdir in

Dave
-- 
J. David Anglin                                  address@hidden
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]