Re: cwrapper generates long strings.

[Ralf Wildenhues]

* Peter Rosin wrote on Mon, Oct 04, 2010 at 10:02:15AM CEST:
> 
> I wrote a loop appending the first PATH component until the length
> exceeds the limit.  The longest possible PATH should be 499 characters
> this way, which seems OK to me, and it should have no "wild" components.

Cool.

> Den 2010-10-04 07:00 skrev Ralf Wildenhues:
> > * Peter Rosin wrote on Sun, Oct 03, 2010 at 08:28:47PM CEST:
> >>> This length doesn't yet trigger the compiler string literal length
> >>> limit; not sure whether it should?
> >>
> >> That's not reliable anyway as most compilers support so long strings
> >> that it's hard to tickle it.
> > 
> > FWIW, that is not necessary.  It would be sufficient if it were tickled
> > with the one compiler in question.
> 
> Since the compiler limit in this case is as large as 2048 (whoooa), which
> is about the same as you quoted for grep, I decided to not do that.

Good point.

The updated patch is fine.

Thanks,
Ralf

> Subject: [PATCH] cwrapper: split long lines when dumping the wrapper script.
> 
> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src): If
> the wrapper script contains long lines, split them for
> readability and to conform with C standards.
> * tests/cwrapper.at (cwrapper string length): New test, making
> sure we don't regress.