[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.
From: |
Peter Rosin |
Subject: |
Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length. |
Date: |
Thu, 16 Sep 2010 19:58:38 +0200 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 |
Den 2010-09-16 19:25 skrev Ralf Wildenhues:
> Hi Peter,
>
> * Peter Rosin wrote on Mon, Sep 13, 2010 at 10:03:10AM CEST:
>> Ok to push this time?
>
> Okay.
>
> I think it ought to be possible to clean up the logic a bit further, to
> make it easier to follow when you read the whole paragraph of code, but
> such a cleanup is just as good to make alongside the eval fixes, and
> early in the release cycle.
>
> BTW, how about s/try_normal_branch/nm_tool_conversion_needed/ and swap
> yes and no? Strictly optional, and only if you prefer that.
I was renaming that variable half a dozen times but never found a name
I was satisfied with. The problem with nm_tool_conversion_needed is
that it might be needed, but not working.
So, I'm pushing as is.
And thanks for the review! I should also add that with this patch in, it
is ok to make the release from my point of view.
Cheers,
Peter
- Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length., (continued)
- Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length., Peter Rosin, 2010/09/11
- Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length., Ralf Wildenhues, 2010/09/12
- How many spaces after a period? [WAS: Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.], Gary V. Vaughan, 2010/09/12
- Re: How many spaces after a period? [WAS: Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.], Ralf Wildenhues, 2010/09/12
- Re: How many spaces after a period? [WAS: Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.], Karl Berry, 2010/09/12
- Re: How many spaces after a period?, Gary V. Vaughan, 2010/09/13
- Re: How many spaces after a period?, Karl Berry, 2010/09/13
- Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length., Peter Rosin, 2010/09/13
- Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length., Peter Rosin, 2010/09/13
- Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length., Ralf Wildenhues, 2010/09/16
- Re: [PATCH 7/7] Prefer $NM @file over calculating the cmd line length.,
Peter Rosin <=
Re: [PATCH 0/7] Support for toolchains that are not $build-native., Peter Rosin, 2010/09/05