libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'


From: Peter O'Gorman
Subject: Re: [PATCH] Correct typo: $sharedlib_from_linklib_cmd missing '_cmd'
Date: Sat, 11 Sep 2010 12:37:41 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5

On 09/11/2010 10:09 AM, Charles Wilson wrote:
On 9/11/2010 2:47 AM, Peter Rosin wrote:
Den 2010-09-11 07:02 skrev Charles Wilson:
OK to push as obvious?

To me, pushing as obvious is the same as pushing without
asking (and when I do, I make damn sure I don't push anything
bad). This makes me curious, what does it mean to you?

It means other than ensuring that I didn't do something stupid like
breaking 'make', I didn't try to do any before/after testing to prove
that this "fixed" whatever the typo apparently "broke".  But the change
is obviously correct, and should't really need that kind of justification.

However...I don't have the authority to push *anything* without
approval, so I *can't* simply say "pushed as obvious".

It is ok for anyone with commit access to commit obvious patches without approval.

Peter




reply via email to

[Prev in Thread] Current Thread [Next in Thread]