Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

[Peter Rosin]

Den 2010-09-10 19:19 skrev Ralf Wildenhues:
> * Peter Rosin wrote on Fri, Sep 10, 2010 at 03:11:39PM CEST:
>> 1. Not covered, you'd need to link a program with -dlopen self,
>> but also with a non-libtool object (.o) and/or an non-libtooled old
>> archive (.a). Neither appears to happen in the testsuite. I don't know
>> why the code isn't exporting symbols from libtool objects (.lo). mdemo
>> and stresstest both use object.lo, so they do not trigger this code
>> path, but almost. So, a previous testsuite deficiency that should not
>> hold back this patch.
> 
> Adding coverage for this added to my TODO list.  Sounds like a fairly
> unportable endeavor though, so it's clear that it's not top priority.

Yes, my thinking too.

>> 4. Probably covered by mdemo too, but you would need a setup that needs
>> func_to_tool_file on something that's not a Windows $host, which I don't
>> have access to.
> 
> Hmm.  We don't have such a thing ATM, right?  I mean, a non-w32 $host
> which needs a nontrivial func_to_tool_file?

No, not that I know of.

> No you don't.  Please commit.

Pushed, thanks!

Cheers,
Peter