Re: [PATCH 6/7] Convert file name to toolchain format when invoking $NM.

[Peter Rosin]

Den 2010-09-09 18:02 skrev Charles Wilson:
> After all, the point of that patch was to correct the FAILURE of that
> particular test!
> 
> So, somewhere between 2009-01 and e83da49a, some OTHER change to libtool
> fixed (?) the mdemo test on mingw/msys.
> 
> Sigh.

Doesn't look like it.

4efe88d335c419ca926a31dc5 "ChangeLog: fix whitespace."    2008-12-19 and
5f24ee188d215eb1f54b13800 "Fix sed script in install.at." 2009-02-01
are both "good" (both MinGW and Cygwin) so something is indeed fishy.

Some change in binutils? gcc-3 vs gcc-4?

Are you sure it wasn't 2007-01? :-)

> I'm no expert on git bisect; if it's not to much trouble, could you
> attempt to determine when, after 2009-01, mdemo started to work on
> mingw/msys?  (Actually, localizing that on cygwin might be good enough,
> if you don't have msysgit installed)

I'm no regular bisector either, and I did it all manually, I think I
shaved off at least some bifurcations by guessing intelligently...

When I saw where it was heading I originally thought it would be the
infamous "Add func_append_quoted and do inline func_append substitutions"
commit from about a week earlier and then I worried that some of my
MSVC patches would be the cause.

> P.S. In my defense, the patch in question fixed *multiple* issues with
> the whole symbol extraction behavior when both static and shared libs
> exist; some of which were just bad practice but wouldn't actually cause
> mdemo to fail.  See the description here:
> http://lists.gnu.org/archive/html/libtool-patches/2010-06/msg00163.html

Yes yes, I assume that the patch is almost correct. I bet something
silly is going on.

Cheers,
Peter