libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFT PATCH v4 6/8] emit sysrooted paths when installing .la files


From: Ralf Wildenhues
Subject: Re: [RFT PATCH v4 6/8] emit sysrooted paths when installing .la files
Date: Sun, 1 Aug 2010 20:31:28 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

* Paolo Bonzini wrote on Sun, Aug 01, 2010 at 04:47:32PM CEST:
> * libltdl/config/ltmain.m4sh (func_replace_sysroot): New.
> (func_mode_link): Prepend paths in $libdir with the sysroot.  Further,
> replace the sysroot with = (using func_replace_sysroot) whenever
> such a path is written in a .la file.

> --- a/libltdl/config/ltmain.m4sh
> +++ b/libltdl/config/ltmain.m4sh

> @@ -8064,7 +8093,7 @@ EOF
>               eval libdir=`${SED} -n -e 's/^libdir=\(.*\)$/\1/p' $lib`
>               test -z "$libdir" && \
>                 func_fatal_error "\`$lib' is not a valid libtool archive"
> -             func_append newdlfiles " $libdir/$name"
> +             func_append newdlfiles " ${lt_sysroot:+=}$libdir/$name"

Although it is fairly unlikely, I prefer not relying on :+ support, so
please replace with 'if test -z "$lt_sysroot"...'.  Two instances.

>               ;;
>             *) func_append newdlfiles " $lib" ;;
>             esac
> @@ -8083,7 +8112,7 @@ EOF
>               eval libdir=`${SED} -n -e 's/^libdir=\(.*\)$/\1/p' $lib`
>               test -z "$libdir" && \
>                 func_fatal_error "\`$lib' is not a valid libtool archive"
> -             func_append newdlprefiles " $libdir/$name"
> +             func_append newdlprefiles " ${lt_sysroot:+=}$libdir/$name"
>               ;;
>             esac
>           done




reply via email to

[Prev in Thread] Current Thread [Next in Thread]