Re: [RFT PATCH v3 3/9] add --with-sysroot

[Paolo Bonzini]

On Thu, Jul 29, 2010 at 10:01, Charles Wilson
<address@hidden> wrote:
> On 7/28/2010 7:23 PM, Paolo Bonzini wrote:
>> * libltdl/m4/libtool.m4 (_LT_HOST_NONCANONICAL, _LT_WITH_SYSROOT): New.
>> (LT_SETUP): Require _LT_WITH_SYSROOT.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>         Right now the default is to use a sysroot.
>
> Are you sure about this?
>
>> +AC_ARG_WITH([sysroot],
>> +[  --with-sysroot[=DIR] Search for dependent libraries within DIR
>> +                        (or the compiler's sysroot if not specified).],
>> +[], [with_sysroot=no])
>
> The fouth argument is the default action (what to do with --*-sysroot is
> not specified).  But:
>
> +lt_sysroot=
> +case ${with_sysroot} in #(
> ...
> + no)
> +   ;; #(
> ...
>
> e.g. do nothing special.  Seems like you'd want the default action to be
> with_sysroot=yes, for the comment (and NEWS entry) to be correct.

No, seems like I was too tired as well. :)

Paolo