[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: MSVC: MSVC needs a hint to force it to compile either as C or C++.
From: |
Charles Wilson |
Subject: |
Re: MSVC: MSVC needs a hint to force it to compile either as C or C++. |
Date: |
Tue, 22 Jun 2010 08:10:05 -0400 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
On 6/22/2010 7:54 AM, Gary V. Vaughan wrote:
> But compile_tag is never set, so the patch is a NOP!
>
> If that happens with a later patch in your series, please roll all
> the compile_tag machinery into a single commit.
But what if that later patch, in order to work correctly, also requires
additional prep work? You're possibly opening up a spiderweb of
inter-dependencies between patches.
I could easily see a series of "nop" patches, each of which is small and
easily reviewed in isolation, but all of which are necessary for a
single, final "do it" patch. You might be asking, in effect, for "do
it" + "all the nops" to be rolled together and presented at once -- in
a large, complex, difficult to review patch.
Peter has already split his mega patch into small, easily digestible
chunks with minimal inter-dependencies. Let's not second guess his
decomposition...
--
Chuck
- MSVC: MSVC needs a hint to force it to compile either as C or C++., Peter Rosin, 2010/06/22
- Re: MSVC: MSVC needs a hint to force it to compile either as C or C++., Peter Rosin, 2010/06/22
- Re: MSVC: MSVC needs a hint to force it to compile either as C or C++., Peter Rosin, 2010/06/23
- Re: MSVC: MSVC needs a hint to force it to compile either as C or C++., Charles Wilson, 2010/06/23
- Re: MSVC: MSVC needs a hint to force it to compile either as C or C++., Ralf Wildenhues, 2010/06/23