|
From: | Peter Rosin |
Subject: | Re: LT_AT_MAKE doesn't terminate the test on failure. |
Date: | Tue, 08 Jun 2010 20:38:32 +0200 |
User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9) Gecko/20100317 Thunderbird/3.0.4 |
Den 2010-06-08 19:35 skrev Ralf Wildenhues:
* Peter Rosin wrote on Tue, Jun 08, 2010 at 03:07:05PM CEST:Sorry to reply to self, but the issue is that there is a subshell in LT_AT_MAKE (there's one in LT_AT_CONFIGURE too) which stops the exit from propagating all the way to where it's supposed to.Good observation! I really wonder how I managed to overlook that for so long.Maybe adding the following after the end bracket of the sub-shells in those two macros is acceptable? $at_failed&& at_fn_log_failureNo, that is definitely too much internals for my taste. This patch should work however. OK?
The LT_AT_MAKE part reports correct line numbers anyway. Thanks! Standalone Libltdl. 77: compiling softlinked libltdl FAILED (standalone.at:35) 78: compiling copied libltdl FAILED (standalone.at:50) 79: installable libltdl FAILED (standalone.at:67) Cheers, Peter
[Prev in Thread] | Current Thread | [Next in Thread] |