[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Update and simplify all m4sh scripts to use latest getopt.m4
From: |
Gary V. Vaughan |
Subject: |
Re: [PATCH] Update and simplify all m4sh scripts to use latest getopt.m4sh. |
Date: |
Sun, 6 Jun 2010 17:04:11 +0700 |
Hallo Ralf,
On 6 Jun 2010, at 16:50, Ralf Wildenhues wrote:
> * Gary V. Vaughan wrote on Sat, Jun 05, 2010 at 11:08:47AM CEST:
>> Itchy trigger finger. I meant to add:
>>
>> Okay to push?
>
> Well, the M4SH_GETOPTS part certainly is rather hard to read because of
> those long lines and long indents.
This part? I thought it much easier to read than the shell loop it replaces.
Although it looks like git-format-patch messed up the tabstops in the version
I posted.
> +dnl SHORT LONG DEFAULT INIT
> +dnl ----------------------------------------------------------------------
> +dnl There are several options supported below for backwards compatibility,
> +dnl but which are not mentioned in the help.
> +M4SH_GETOPTS(
> + [C^!], [--carbon-copy], [], [],
> + [F^!], [--from], [], [],
> + address@hidden, [--filename], [], [],
> + address@hidden, [--headers], [], [],
> + [m+!], [--mime-type], [], [
> + case [$]1 in
> + text/*) ;;
> + */*) func_error "\`[$]1': only text/* mime-types supported"
> + ;;
> + *) func_error "invalid mime-type, \`[$]1'"
> + exit_cmd=exit
> + ;;
> + esac],
> + [n], [], [], [],
> + [o!], [--output-file], [], [],
> + [s^!], [--subject], [], [],
> + [v], [--verbose], [], [],
> + [], [--dry-run|--dryrun], [], [],
Of course, that assumes that you can trust the implementation of M4SH_GETOPTS
that I commited with announce-gen, and used to make the 2.2.8 release message.
> Other than that, I don't actually
> use either of those scripts for patch handling, so if the changes work
> for you and others that use them ...
I've used them successfully for the entire last round of patches and releases,
so I'll take that as an implicit "okay" :)
Cheers,
--
Gary V. Vaughan (address@hidden)