Re: Use GetErrorMode if it is available (on Windows Vista and above).

[Ralf Wildenhues]

Hi Peter,

* Peter Rosin wrote on Sat, Jan 02, 2010 at 12:29:11PM CET:
> >>Here's another patch, it makes use of the new function GetErrorMode,
> >>if available, instead of cludging it by calling SetErrorMode twice.
> >>GetErrorMode was introduced with Windows Vista.
> >>
> >>This patch does not apply cleanly to a clean git repo, it changes
> >>lines too close to the previous error reporting patch(es), but it
> >>is orthogonal.
> >
> >Oops, forgot the patch...
> 
> Oops, old version of the patch (GetProcAddressA doesn't exist, this
> version uses GetProcessAddress). Sorry for the inconvenience.

I can't judge w32 code at all, so I believe you when you say the old
version was a kludge.  In what way, though?  Did it provide less
functionality, were we using something "deprecated" by the vendor, or
are we just pleasing aesthetics here?

Have you tested it on some system that has GetErrorMode (Vista) and some
that doesn't (something older)?

Thanks,
Ralf

> 2010-01-02  Peter Rosin  <address@hidden>
> 
>       Use GetErrorMode if it is available.
>       * libltdl/loaders/loadlibrary.c (wrap_geterrormode): New
>       function that checks if GetErrorMode is supported by the
>       system and makes use of it if it is.
>       (fallback_geterrormode): New function that is used otherwise
>       that implements the old workaround.
>       (geterrormode): New function pointer that points at either
>       of the above or directly at GetErrorMode.
>       (vm_open): Make use of the above.