libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix bindir and dlopen tests for C++ compilers (CC=g++).


From: Peter Rosin
Subject: Re: Fix bindir and dlopen tests for C++ compilers (CC=g++).
Date: Mon, 30 Nov 2009 20:15:22 +0100
User-agent: Thunderbird 2.0.0.23 (Windows/20090812)

Den 2009-11-30 16:47 skrev Bob Friesenhahn:
On Mon, 30 Nov 2009, Ralf Wildenhues wrote:

Well, the cast only looks random as long as we don't know a good
rationale for it, I guess.

I should mention that there is a very good reason why strrchr() should return 'const char *'. The reason is that the input string is 'const char *' and since the returned string points into the input string, it would be wrong for it to not also be 'const char *'

Right, this is perhaps a better fix?

2009-11-30  Peter Rosin  <address@hidden>

        Please C++ compilers when calling strrchr.

        * libltdl/ltdl.c (has_library_ext): Match the return type of
        strrchr with the first argument to please C++ compilers.
        Report by Peter O'Gorman.

Cheers,
Peter

--
They are in the crowd with the answer before the question.
> Why do you dislike Jeopardy?

Attachment: const_strrchr.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]