Re: Small patch for the QNX platform

[Ralf Wildenhues]

Oh my, what an unfinished old thread, sorry for forgetting about it:
<http://thread.gmane.org/gmane.comp.gnu.libtool.patches/9063/focus=9172>

* Ralf Wildenhues wrote on Sun, Feb 01, 2009 at 04:24:30PM CET:
> * Mike Gorchak wrote on Fri, Jan 23, 2009 at 07:09:18AM CET:
> > This patch adds qnx as platform which supports library version information.
> >
> > --- ./libtool-2.2.6/libltdl/config/ltmain.m4sh 2008-09-07 
> > 20:54:53.000000000 +0300
> > +++ ./libtool-2.2.6-qnx/libltdl/config/ltmain.m4sh 2009-01-23  
> > 08:01:41.000000000 +0200
> > @@ -5746,7 +5746,7 @@
> >    # which has an extra 1 added just for fun
> >    #
> >    case $version_type in
> > -   darwin|linux|osf|windows|none)
> > +   darwin|linux|osf|windows|qnx|none)
> >      func_arith $number_major + $number_minor
> >      current=$func_arith_result
> >      age="$number_minor"
> 
> Thinking about this a bit more, and working on versioning.at, I gather
> the above change is wrong.  Well, at least it is inconsistent with the
> rest of the qnx version_type:
>         qnx)
>           major=".$current"
>           versuffix=".$current"
> 
> This means that your major is not CURRENT - AGE, so we should not try to
> compute current as MAJOR + MINOR.  At least that's what the comment
> before your change indicates:

As indicated, I'm applying this patch instead.  The versioning tests,
also from that old thread, will expose this issue with your version of
the patch.

Cheers,
Ralf

2009-06-14  Mike Gorchak  <address@hidden>  (tiny change)
            Ralf Wildenhues  <address@hidden>

        Fix versioning computation for QNX.
        * libltdl/config/ltmain.m4sh (func_mode_link): Set `$current'
        and `$age' properly for version_type `qnx'.

diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 02f4d21..6f44d35 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -5928,7 +5928,7 @@ func_mode_link ()
            age="$number_minor"
            revision="$number_revision"
            ;;
-         freebsd-aout|freebsd-elf|sunos)
+         freebsd-aout|freebsd-elf|qnx|sunos)
            current="$number_major"
            revision="$number_minor"
            age="0"