libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: versioning test


From: Ralf Wildenhues
Subject: Re: versioning test
Date: Sat, 31 Jan 2009 11:30:32 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Hi Mike,

* Mike Gorchak wrote on Tue, Jan 27, 2009 at 08:56:25AM CET:
> > RW>>   cd tests/testsuite.dir/16
> > RW>>   ./libtool --debug --mode=link --tag=CC qcc -V3.3.5,gcc_ntox86 -O3
> > RW>> \            -funroll-all-loops -o libconv.la \            1/a.lo
> > RW>> 2/a.lo 3/a.lo 4/a.lo 5/a.lo libc0.la
> >> There is no tests/testsuite.dir/16 directory. I've 15, 17, 26, 35, 38,
> >> 68, 74 only. What do I need to create it ?
> RW> I meant 15.  Sorry for the typo.
>
> Log attached.

Thanks.  func_basename is working.  It seems your sort program is not
working as expected:
  ( echo a.o; echo a.o ) | sort | sort -uc; echo $?

should show a nonzero exit status, but apparently it doesn't on your
system.  Can you report this bug to the QNX people (which "sort"
implementation is this BTW)?

For now I've pushed a trivial patch wrapping some of the link commands
in the test group in AT_CHECK, so they are checked more closely (patch
below); and added you to THANKS.

Cheers,
Ralf

        Use AT_CHECK more liberally in duplicate members test.
        * tests/duplicate_members.at (duplicate members in archive
        tests): Wrap link commands in AT_CHECK, they might fail, as seen
        on QNX.
        * THANKS: Update.
        Report by Mike Gorchak.

diff --git a/tests/duplicate_members.at b/tests/duplicate_members.at
index 657e307..4f054f7 100755
--- a/tests/duplicate_members.at
+++ b/tests/duplicate_members.at
@@ -61,13 +61,16 @@ do
   $LIBTOOL --mode=compile --tag=CC $CC $CPPFLAGS $CFLAGS -c -o $a/a.lo $a/a.c
 done
 $LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libc0.la 6/a.lo
-$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libconv.la 1/a.lo 2/a.lo 
3/a.lo 4/a.lo 5/a.lo libc0.la
+AT_CHECK([$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libconv.la ]dnl
+        [1/a.lo 2/a.lo 3/a.lo 4/a.lo 5/a.lo libc0.la], [], [ignore], [ignore])
 
 $LIBTOOL --mode=compile --tag=CC $CC $CPPFLAGS $CFLAGS -c -o bar.lo bar.c
-$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libbar.la bar.lo 
libconv.la -rpath /notexist
+AT_CHECK([$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o libbar.la ]dnl
+        [ bar.lo libconv.la -rpath /notexist], [], [ignore], [ignore])
 
 $LIBTOOL --mode=compile --tag=CC $CC $CPPFLAGS $CFLAGS -c -o main.lo main.c
-$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o main$EXEEXT main.lo 
./libbar.la
+AT_CHECK([$LIBTOOL --mode=link --tag=CC $CC $CFLAGS $LDFLAGS -o main$EXEEXT 
]dnl
+        [main.lo ./libbar.la], [], [ignore], [ignore])
 
 LT_AT_EXEC_CHECK([./main],[0],[ignore],[ignore])
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]