Re: Unify line endings in localization test

[Ralf Wildenhues]

* Peter Rosin wrote on Tue, Jan 20, 2009 at 12:34:57AM CET:
> Den 2009-01-19 21:35 skrev Ralf Wildenhues:
>> This looks a bit hackish.  We already have a handful of places which we
>> fixed up in order to avoid line ending issues.  This one looks hackish
>> enough to deserve being wrapped in a macro (in testsuite.at, below
>> LT_AT_HOST_DATA?), so that future instances of this issue can easily be
>> handled likewise.
>
> Something like the attached?

Yes, with nits below addressed.

> --- a/tests/testsuite.at
> +++ b/tests/testsuite.at
> @@ -204,6 +204,19 @@ case $host_os in mingw*)
>  esac])
>  
>  
> +# LT_AT_UNIFY_NL(FILE, [RESULT-FILE])
> +# --------------------

Let's underline the whole text.  :-)

> +# Ensure (text) file has predicable line endings.

FILE.  Please describe RESULT-FILE.  Typo "predictable".

> +m4_define([LT_AT_UNIFY_NL],
> +[case $host_os in
> + mingw*)
> +  tr -d '\015' < $1 > m4_ifval([$2], [$2], [$1.t
> +  mv -f $1.t $1]) ;; m4_ifval([$2], [
> + *)
> +  mv -f $1 $2 ;;])
> +esac])

1 or 2 characters of indentation?  ;-)

An even easier-to-use interface would be an LT_AT_CHECK_FF or so,
which would check after converting to a standard file format.
But the above is good enough, and easy enough to use, and the
full solution would require us to hack up more, with LT_AT_EXEC_CHECK
and all.  So let's use this.

Thanks,
Ralf