libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.


From: Charles Wilson
Subject: Re: [PATCH] [cygwin|mingw] Fix compile warnings when -std=c89.
Date: Wed, 21 Jan 2009 10:21:01 -0500
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.19) Gecko/20081209 Thunderbird/2.0.0.19 Mnenhy/0.7.5.666

Peter Rosin wrote:
> Den 2009-01-16 15:15 skrev Charles Wilson:
>> Charles Wilson wrote:
>>> Charles Wilson wrote:
>>>> * libltdl/config/ltmain.m4sh: Update copyright date.
>>>> (func_emit_wrapper_part1): move contents to...
>>>> (func_emit_wrapper_part2): move contents to...
>>>> (func_emit_wrapper): here.
>>>> (func_emit_cwrapperexe_src) [file scope]: re-organized
>>>> includes and portability macros. Avoid oldnames on MINGW32
>>>> and MSVC for setmode/stat/chmod/getcwd/putenv. Declare
>>>> _putenv on MINGW32 when -ansi. Use namespaced macro
>>>> LT_DEBUGWRAPPER. Remove variables script_text_part1 and
>>>> script_text_part2.
>>>> (func_emit_cwrapperexe_src) [lt_dump_script]: New function.
>>>> (func_emit_cwrapperexe_src) [main]: Call it.
>>> Ping?
>>>
>> Ping x 2?
> 
> I tried this patch on the pr-msvc-support branch and it seems
> to work just fine there as well (tested with MSVC 2005).

Thanks, Peter; your validation on msvc is useful and encouraging.  Now
I'm just waiting for a go/no-go from one of the four libtool
maintainers: Gary Vaughan, Peter O'Gorman, Ralf Wildenhues, or Bob
Friesenhahn.

Status:
This patch was successfully tested by Roumen Petrov (on master,
unix->mingw cross)
http://lists.gnu.org/archive/html/libtool-patches/2009-01/msg00012.html
and by Peter Rosin (on pr-msvc-support branch, msys/msvc2005 "native")
http://lists.gnu.org/archive/html/libtool-patches/2009-01/msg00060.html
-- and me, msys/mingw native
http://lists.gnu.org/archive/html/libtool-patches/2009-01/msg00005.html

--
Chuck




reply via email to

[Prev in Thread] Current Thread [Next in Thread]