[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix --verbose option and add new --no-silent option
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Fix --verbose option and add new --no-silent option |
Date: |
Fri, 21 Nov 2008 19:47:28 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi Charles,
apologies: I actually wrote this reply a few days ago, and then forgot
to send it. :-(
Sorry.
* Charles Wilson wrote on Mon, Nov 17, 2008 at 02:31:56AM CET:
> +Thus, to restore the default state, the following two options
> +must be given (in order):
> address@hidden
> address@hidden ... --silent --no-silent ...}
Ah, I didn't think of that. In this case, we should have --no-verbose,
too. Its description can simply be "undo effects of @option{--verbose}".
> --- a/NEWS
> +++ b/NEWS
> @@ -6,6 +6,15 @@ New in 2.2.8 2008-??-??: git version 2.2.7a, Libtool team:
>
> - Libtool ships and installs man pages for libtool and libtoolize now.
> - New libtool command line flag --help-all.
> + - New libtool command line flag --no-silent (with alternate spelling
> + --no-quiet). This flag (re)enables the default informational messages,
> + but has no effect on so-called "verbose" output messages.
This is good, maybe a bit verbose. ;-)
NEWS may be terse, unlike the manual.
> + Ignoring --debug, there are now four different message levels:
> + normal verbose
> + (default) ON OFF
> + --silent OFF OFF
> + --verbose ON ON
> + --no-silent ON (previous)
I think you can omit this here; users can check the manual for details.
> @@ -13,6 +22,9 @@ New in 2.2.8 2008-??-??: git version 2.2.7a, Libtool team:
> with Autoconf 2.59 (`possibly undefined macro: LT_LIBEXT').
> - Fix 2.2.4 regression that caused arguments with special characters
> to be mangled by the compile wrapper for uninstalled programs on MinGW.
> + - libtool command line flag --verbose now also enables explicit
> + verbose output, in addition to its previous behavior of (re)enabling
> + only the default informational output. See New Features, --no-silent.
OK.
If you agree, then go ahead and commit with needed changes.
Thanks,
Ralf