libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/6] tweak to config.status->libtool quoting (correct?)


From: Ralf Wildenhues
Subject: Re: [PATCH 4/6] tweak to config.status->libtool quoting (correct?)
Date: Sun, 9 Nov 2008 21:28:45 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

* Paolo Bonzini wrote on Fri, Nov 07, 2008 at 01:02:44PM CET:
> * libltdl/m4libtool.m4 (_LT_OUTPUT_LIBTOOL_COMMANDS_INIT): Double
> quote ECHO-ed variable.

At one point, I was fairly certain that this whole section could be done
*a lot* simpler and more efficient.  I forgot the details about what I
was thinking back then.  But 2 seconds of thought tell me: let
'config.status --file' do the job of filling in variables.  We ensure
awk can substitute almost any character.

The biggest problem with this code part is that it slows down
config.status by so much, requiring some 50odd forks or so (don't
remember).

Anyway, this patch looks good, if you don't want to redo the whole
thing.

Thanks,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]