Re: [PATCH] Ensure cwrapper compiles without warnings under -std=c99.

[Gary V. Vaughan]

Hi Chuck,

On 6 May 2008, at 22:47, Charles Wilson wrote:
> Unresolved:
>
> (1) whether func_emit_wrapper_part1 should even TAKE an argument
>
> (2) whether the cwrapper src, when printing a const char*, should  
> use puts() in preference to printf("%s",...)


The quality of your patches has always been exemplary, and I trust you  
to
make a sensible decision.

To prevent us all from getting caught up in a democratic committee  
meeting
to approve the colour of the bike shed, just pick a nice colour and go  
ahead
and paint it!  I've long been of the opinion that any patch that doesn't
receive negative criticism within 72 hours of posting is fair game to be
applied to the repository. :-)

Please go ahead and choose however you think best and then push the  
patch.

(For the record, I personally believe that maintainability is king, and
always strive to make my patches look like the code that surrounds them)

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_

PGP.sig
Description: This is a digitally signed message part