[PATCH] Ensure $OBJDUMP is defined

[Charles Wilson]

2008-05-05  Charles Wilson  <...>
            Yaakov Selkowitz  <...> 

        Ensure $OBJDUMP is defined
        * libltdl/m4/libtool.m4 (_LT_DECL_OBJDUMP): new macro ensures
        that $OBJDUMP is always defined sanely.
        (_LT_SYS_DYNAMIC_LINKER): call it.
        (_LT_CHECK_MAGIC_METHOD): call it.

---
Resubmission of 
http://lists.gnu.org/archive/html/libtool-patches/2008-04/msg00098.html, with 
objectionable LT_INIT-related changes removed.

Okay for push?

And somebody please tell me if there's more to it than just 'git push' 
once you've
 (1) cherry-picked from your (rebased) topic branch into your local master
 (2) updated the ChangeLog
 (3) git-add ChangeLog
 (4) git commit --amend -e
With CVS, instead of 'cvs commit' you'd do 'clcommit'
With GIT, instead of 'git push' you do ... what?


 libltdl/m4/libtool.m4 |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/libltdl/m4/libtool.m4 b/libltdl/m4/libtool.m4
index 4ceb7f1..4d31e80 100644
--- a/libltdl/m4/libtool.m4
+++ b/libltdl/m4/libtool.m4
@@ -2035,6 +2035,7 @@ m4_defun([_LT_SYS_DYNAMIC_LINKER],
 [AC_REQUIRE([AC_CANONICAL_HOST])dnl
 m4_require([_LT_DECL_EGREP])dnl
 m4_require([_LT_FILEUTILS_DEFAULTS])dnl
+m4_require([_LT_DECL_OBJDUMP])dnl
 m4_require([_LT_DECL_SED])dnl
 AC_MSG_CHECKING([dynamic linker characteristics])
 m4_if([$1],
@@ -2956,6 +2957,7 @@ _LT_DECL([], [reload_cmds], [2])dnl
 #  -- PORTME fill in with the dynamic library characteristics
 m4_defun([_LT_CHECK_MAGIC_METHOD],
 [m4_require([_LT_DECL_EGREP])
+m4_require([_LT_DECL_OBJDUMP])
 AC_CACHE_CHECK([how to recognize dependent libraries],
 lt_cv_deplibs_check_method,
 [lt_cv_file_magic_cmd='$MAGIC_CMD'
@@ -6970,6 +6972,18 @@ AC_SUBST([GREP])
 ])
 
 
+# _LT_DECL_OBJDUMP
+# --------------
+# If we don't have a new enough Autoconf to choose the best objdump
+# available, choose the one first in the user's PATH.
+m4_defun([_LT_DECL_OBJDUMP],
+[AC_CHECK_TOOL(OBJDUMP, objdump, false)
+test -z "$OBJDUMP" && OBJDUMP=objdump
+_LT_DECL([], [OBJDUMP], [1], [An object symbol dumper])
+AC_SUBST([OBJDUMP])
+])
+
+
 # _LT_DECL_SED
 # ------------
 # Check for a fully-functional sed program, that truncates
-- 
1.5.5.1