Re: [PATCH 368 bis] New libtoolize --no-warn option and LIBTOOLIZE_OPTIONS parsing.

[Gary V. Vaughan]

Hi Bob,

Thanks for the review.

On 29 Apr 2008, at 19:34, Bob Friesenhahn wrote:
> On Tue, 29 Apr 2008, Gary V. Vaughan wrote:
> > I hope this will allay Bob's concerns for users who want to stick
> > with deprecated macro interfaces, and don't want libtoolize to nag
> > them to upgrade, even while some stubborn project developers refuse
> > to upgrade to a libtool release that will help them do that. :-p
> >
> > Okay to push?
>
> This is definitely better, but there are still a few concerns.  The  
> text describing "New features" lists several libtool options which  
> may be passed via the environment variable, but not this new --no- 
> warn option.

--no-warn is mentioned in the ChangeLog, NEWS and several times in the  
texinfo documentation including an example.  I can't see where you're  
missing it from...

> The term "bailed out" may be confusing to people who are not  
> primarily english speakers.  It seems best to use terms (e.g.  
> "quit") which are straightforward dictionary translations.

Okay, done.

> If you fix these few issues, then the patch seems ok to me.


I'll push presently.

Cheers,
        Gary
--
  ())_.              Email me: address@hidden
  ( '/           Read my blog: http://blog.azazil.net
  / )=         ...and my book: http://sources.redhat.com/autobook
`(_~)_

PGP.sig
Description: This is a digitally signed message part