Re: [PATCH 365] Only complain that files are up-to-date with --force.

[Ralf Wildenhues]

Hi Gary,

* Gary V. Vaughan wrote on Tue, Apr 22, 2008 at 08:49:54AM CEST:
> Okay to Apply?

I'd say yes.  I have some nits below; I haven't had the time to check
all the logic changes in detail, but I suppose user feedback will weed
out remaining issues.  ;-)

Thank you very much for tackling this!

> --- a/libtoolize.m4sh
> +++ b/libtoolize.m4sh
> @@ -202,7 +202,24 @@ configure_ac=configure.in
>  }
>  
>  
> -# func_copy srcfile destfile
> +# func_echo_once msg_var
> +# Calls func_echo with the value of MSG_VAR, and then sets MSG_VAR="" so
> +# that subsequent calls have no effect.
> +func_echo_once ()
> +{
> +    $opt_debug
> +    if test -n "$1"; then
> +      my_msg=`eval echo \\\$$1`

Can this line be simplified to
  eval my_msg=\$$1
?

> +      if test -n "$my_msg"; then
> +        func_echo "$my_msg"
> +        eval $1=""

Those double quotes are pretty superfluous, as they won't survive the
eval.  Not that they are a problem at all.  :-)

> +      fi
> +    fi
> +}
> +

> --- a/tests/testsuite.at
> +++ b/tests/testsuite.at
> @@ -73,8 +73,9 @@ AT_KEYWORDS([libtoolize])
>  # ---------------------------
>  # Fix the expected output of installed libtoolize in presence of --program-*.
>  m4_define([_LIBTOOLIZE_TRANSFORM],
> -[lt_name=`$ECHO "$LIBTOOLIZE" | sed 's,^.*/,,'` # restore font-lock: ''
> -sed "s/^libtoolize/$lt_name/" < $1 > $1.t
> +[lt_name=`$ECHO "$LIBTOOLIZE" | sed "s,^.*/,,"`
> +sed "s/^libtoolize/$lt_name/
> +s,/usr/local/share/aclocal/,$abs_top_srcdir/libltdl/m4/," < $1 > $1.t

Maybe better use | as sed s command delimiter in the last line?

Cheers,
Ralf