Re: [patch] quote language related variables in case they have garbage

[Ralf Wildenhues]

Hello Mike,

* Mike Frysinger wrote on Sun, Mar 16, 2008 at 08:36:20AM CET:
> if you set a language variable with quotes or semicolons or other weird
> things, you may get ugly warnings/errors when indirectly evaluating them.

Please provide an example, including all output, that exposes this.
I can't see what case it would fix.

Thanks,
Ralf

> 2008-03-16  Mike Frysinger  <address@hidden>
> 
>       * libltdl/config/ltmain.m4sh (NLS nuisances): Quote vars when setting.
> 
> Index: libltdl/config/ltmain.m4sh
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
> retrieving revision 1.97
> diff -u -p -r1.97 ltmain.m4sh
> --- libltdl/config/ltmain.m4sh        28 Jan 2008 15:49:46 -0000      1.97
> +++ libltdl/config/ltmain.m4sh        16 Mar 2008 07:32:18 -0000
> @@ -99,7 +99,7 @@ DUALCASE=1; export DUALCASE # for MKS sh
>  for lt_var in LANG LANGUAGE LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
>  do
>    eval "if test \"\${$lt_var+set}\" = set; then
> -          save_$lt_var=\$$lt_var
> +          save_$lt_var=\"\$$lt_var\"
>            $lt_var=C
>         export $lt_var
>       fi"
> @@ -1717,7 +1717,7 @@ func_mode_execute ()
>        for lt_var in LANG LANGUAGE LC_ALL LC_CTYPE LC_COLLATE LC_MESSAGES
>        do
>       eval "if test \"\${save_$lt_var+set}\" = set; then
> -                $lt_var=\$save_$lt_var; export $lt_var
> +                $lt_var=\"\$save_$lt_var\"; export $lt_var
>             else
>               $lt_unset $lt_var
>             fi"