Re: 341-gary-libtoolize-recognise-LTDL_INIT

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Gary V. Vaughan on 1/24/2008 9:43 PM:
| Okay to commit?

The patch looks okay, and makes the situation is better than it was, so I
think it is worth committing.  However,...

|   @@ -921,7 +921,7 @@
|       func_echo "and rerunning libtoolize."
|          fi
|        elif test -z "$m4dir"; then
|   -      if $opt_ltdl && test "${ltdlprefix}m4" != "$m4dir"; then
|   +      if test "${ltdlprefix}m4" != "$m4dir" && $seen_ltdl ||
$opt_ltdl; then
|       acmacrodir="${ltdlprefix}m4"
|          else
|       acmacrodir="$aclocaldir"

Technically, we only need to use ${ltdlprefix}m4 if we are distributing
ltdl as a subproject, because that is the only mode where the ltdl
directory must be self-contained.  It would be nice if nonrecursive and
recursive modes would cooperate with an explicit $aclocaldir (and silence
the recommendation about setting AC_CONFIG_AUX_DIR([${ltdlprefix}config]),
since these two modes imply that ltdl is sharing infrastructure with the
rest of the project, rather than the current scenario of the rest of the
project having to conform to libtool's directory structure.

|   +# _LT_AT_LTDL_SETUP
|   +# -----------------
|   +m4_pushdef([_LT_AT_LTDL_SETUP],

Even though this is an internal factorization, a one-liner comment stating
that prior to the actual definition would be helpful.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHmjFm84KuGfSFAYARAkCRAKCEri3PlE5kQINGKQvofcMd85X2lACcC190
8Z+zIAyJDrdl6/pZ/TScDXw=
=c7EW
-----END PGP SIGNATURE-----