Re: Followup patch: fix mingw cross-compile regressions

[Ralf Wildenhues]

Hi Charles,

* Charles Wilson wrote on Thu, Jul 12, 2007 at 08:41:12AM CEST:
> While testing an earlier patch of mine, Ralf reported some old testsuite 
> failures when cross-compiling for mingw from linux:
>
>> Grepping the verbose output of the old HEAD testsuite for 'No such file
>> or directory' shows several bits that need adjustment, too.
>
> The attached adds $EXEEXT in the appropriate places. Tested on cygwin 
> (native) and linux (native) with no regressions.  However, I have NOT 
> tested it in Ralf's use case, which is what it is intended to fix -- 
> somebody else needs to make sure I haven't actually made things worse, 
> there.

This patch is OK.  It causes no regressions for a linux -> mingw cross
compile.  demo-relink is still looking for a nonexistent file, but that
may be intentional.  FYI, here's the two failures of the old suite:

| demo-hardcode.test: ===  Running demo-hardcode.test
| demo-hardcode.test: ===  Running `make hardcode' in demo
| make[4]: Entering directory 
`/home/ralf/download/cvs/libtool/write/HEAD2/build-mingw32/tests/demo'
| You may ignore any linking errors from the following command:
| i586-mingw32msvc-gcc -g -O2 -L/usr/i586-mingw32msvc/lib -o hc-direct main.o 
./.libs/libhello.dll.a  -lm -L/home/ralf/download/Info: resolving _nothing by 
linking to __imp__nothing (auto-import)
| i586-mingw32msvc-gcc -g -O2 -L/usr/i586-mingw32msvc/lib -o hc-libflag main.o 
-L/home/ralf/download/cvs/libtool/write/HEAD2/buiInfo: resolving _nothing by 
linking to __imp__nothing (auto-import)
| You may ignore any linking errors from the following command:
| PATH=./.libs i586-mingw32msvc-gcc -g -O2 -L/usr/i586-mingw32msvc/lib -o 
hc-libpath main.o -lhello  -lm -L/home/ralf/download/c/bin/sh: line 5: 
i586-mingw32msvc-gcc: command not found
| i586-mingw32msvc-gcc -g -O2 -L/usr/i586-mingw32msvc/lib -o hc-minusL main.o 
-L./.libs -lhello  -lm -L/home/ralf/download/cvs/lInfo: resolving _nothing by 
linking to __imp__nothing (auto-import)
| make[4]: Leaving directory 
`/home/ralf/download/cvs/libtool/write/HEAD2/build-mingw32/tests/demo'
| demo-hardcode.test: ===  Finding libtool.m4's guesses at hardcoding values
| = Searching for hardcoded library directories in each program
| .libs was not hardcoded in `hc-direct', as libtool expected
| .libs was not hardcoded in `hc-libflag', which fooled libtool
| `hc-libpath' was not linked properly, as libtool expected
| .libs was not hardcoded in `hc-minusL', as libtool expected
| FAIL: tests/demo-hardcode.test
| demo-relink.test: ===  Running demo-relink.test
| cp: cannot stat `.libs/lt-hell.exe': No such file or directory
| /usr/bin/wine-auto: line 396:  2972 Segmentation fault      
$WINEBIN/$WINE_BIN_NAME "$@"
| Wine failed with return code 139
| ../libtool/tests/demo-relink.test: line 60:  2962 Segmentation fault      
./hell$EXEEXT
| demo-relink.test: ===  removing libhello.la from demo
| demo-relink.test: ===  running demo/hell
| /usr/bin/wine-auto: line 396:  2990 Segmentation fault      
$WINEBIN/$WINE_BIN_NAME "$@"
| Wine failed with return code 139
| ../libtool/tests/demo-relink.test: line 73:  2980 Segmentation fault      
./hell$EXEEXT
| demo-relink.test: Exiting: demo/hell does not run, maybe libhello was not 
installed
| FAIL: tests/demo-relink.test

Thanks,
Ralf

> 2007-07-11  Charles Wilson  <...>
>
>       * tests/cdemo-exec.test: use $EXEEXT where appropriate
>       to correct mingw cross-compile issues.
>       * demo-deplibs.test: Ditto.
>       * demo-exec.test: Ditto.
>       * demo-inst.test: Ditto.
>       * demo-relink.test: Ditto.
>       * depdemo-exec.test: Ditto.
>       * depdemo-inst.test: Ditto.
>       * depdemo-relink.test: Ditto.
>       * f77demo-exec.test: Ditto.
>       * fcdemo-exec.test: Ditto.
>       * mdemo-exec.test: Ditto.
>       * mdemo-inst.test: Ditto.
>       * mdemo2-exec.test: Ditto.
>       * pdemo-exec.test: Ditto.
>       * pdemo-inst.test: Ditto.
>       * tagdemo-exec.test: Ditto.