libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: distchecking without FC?


From: Ralf Wildenhues
Subject: Re: distchecking without FC?
Date: Tue, 19 Jun 2007 20:38:49 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

Hi Noah,

* Noah Misch wrote on Mon, Jun 18, 2007 at 07:43:52AM CEST:
> On Sat, Jun 16, 2007 at 11:13:36AM +0200, Ralf Wildenhues wrote:
> > * Noah Misch wrote on Fri, Jun 15, 2007 at 02:42:04AM CEST:
> > > If better, we could compromise between complexity
> > > and redundancy by generating the list of files at `bootstrap' time.
> > 
> > If you've already tried this, please post the patch.  Thanks.
> 
> I gave this a whirl.  Having done so, I personally prefer the
> simplicity of the literal patch.  What do you think?

FWIW, I prefer this patch slightly: it makes it obvious how to fix it
in case of future breakage (be that because autotools generate more
files, or the tests contain different sets of files).  Unless there are
good reasons against it (such as someone disagreeing with me ;-), I'd
say let's go with this, except for nits below.

> 2007-06-18  Noah Misch  <address@hidden>
> 
>       * bootstrap: Generate tests/test-disk.mk.  Arrange to do this after
>       configuring most directories, but before configuring the top level.
>       * Makefile.am: Include tests/test-dist.mk.
>       (configure-subdirs, @DIST_MAKEFILE_LIST@, DIST_SUBDIRS): Delete.
>       (clean-local-legacy): Delete `config.log' in test directories.
>       * configure.ac (CONF_SUBDIRS, DIST_MAKEFILE_LIST): Delete.

> +  find tests/*demo tests/*demo[0-9] -name '{arch}' -prune -o -type f \
> +    \( \
> +      -name \*.[ch] -o -name \*.cpp -o -name \*.f -o -name \*.f90 \
> +      -o -name configure -o -name configure.ac -o -name aclocal.m4 \
> +      -o -name Makefile.am -o -name \*.in -o -name README \
> +    \) \
> +    -printf 'EXTRA_DIST += %p\n'

  -exec echo 'EXTRA_DIST +=' \{\} \;

instead should be portable to non-GNU find.

> +} >tests/test-dist.mk
> +

> +# Bootstrap `.' last.
> +case $reconfdirs in
> +  . | '. '* | *' . '* | *' .') $AUTORECONF --force --verbose --install ;;
> +esac

Why not simple, like above the `find'?

for sub in $reconfdirs; do
  test "$sub" = . && $AUTORECONF --force --verbose --install
done

distcheck is still running (and will be for some minutes).

Cheers, and thanks,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]