Re: 312-gary-add-license-url.diff

[Ralf Wildenhues]

* Gary V. Vaughan wrote on Wed, Feb 28, 2007 at 12:01:47AM CET:
> Note: adjust libltdl/config/getopt.m4sh:func_version() to compensate
> --------------------------------------------------------------------
> 
> # func_version
> # Echo version message to standard output and exit.
> func_version ()
> {[

For getopt.m4sh, you could extend the M4 double-quoting to the range
starting right after `m4_include([general.m4sh])' and ending at the end
of the file, so that it really is maximally quoted.  Like so:

m4_include([general.m4sh])[

func_version ()
{
...
}
...
exit_cmd=:]


>     $SED -n ': a

There must be no space between ":" and the label name.

>         /[1-9][0-9]*[,-]$/N; s/[1-9][0-9]*[,-]\n# *//; t a

Where did the leniency towards trailing spaces from
<http://lists.gnu.org/archive/html/libtool-patches/2007-02/msg00113.html>
go?  I already approved the patch in that message.  If the only
suggested change now is to add this line:

>         /^#   This file is part of/,/./d

the I suggest you make a patch to only do that.  Consider the one-line
patch approved.

>         /^#   '$PROGRAM' (GNU /,/# warranty; / {
>             s/^#   //
>             s/^# *//

What's the first of these two lines good for?

>             s/\((C)\)[ 0-9,-]*\( [1-9][0-9]*\)/\1\2/
>             p
>          }' < "$progpath"
>      exit $?
> ]}

In order to ensure future that versions of func_version cooperate with
future variants of copyright headers, you may want to write a test.

Cheers,
Ralf