FYI: HEAD: fix bogus warning when linking against convenience archive

[Ralf Wildenhues]

Libtool was bogusly complaining about "unportable" linking of
dlpreloaded convenience archives into libraries.  Which is of course
nonsense: static archives are a potential problem, but not convenience.
You can see this when building libltdl.la on HP-UX/PA, for example.

The fix turned out to be a cheap typo: at this point, $deplib contains
what we need, and $lib is empty.

This is BTW a bug that lived since the grand change to allow libtool to
preopen modules...

Cheers,
Ralf

2007-02-22  Ralf Wildenhues  <address@hidden>

        * libltdl/config/ltmain.m4sh (func_mode_link): Fix the check for
        convenience archives when warning about linking against static
        libraries: test against $deplib rather than empty $lib.

Index: libltdl/config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
retrieving revision 1.63
diff -u -r1.63 ltmain.m4sh
--- libltdl/config/ltmain.m4sh  12 Feb 2007 19:57:24 -0000      1.63
+++ libltdl/config/ltmain.m4sh  22 Feb 2007 19:50:50 -0000
@@ -3373,7 +3373,7 @@
            # Linking convenience modules into shared libraries is allowed,
            # but linking other static libraries is non-portable.
            case " $dlpreconveniencelibs " in
-           *" $lib "*) ;;
+           *" $deplib "*) ;;
            *)
              valid_a_lib=no
              case $deplibs_check_method in