[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FYI: HEAD: new export.at test
From: |
Ralf Wildenhues |
Subject: |
Re: FYI: HEAD: new export.at test |
Date: |
Mon, 12 Feb 2007 21:50:25 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
* quoting myself from Sun, Feb 11, 2007:
>
> * tests/export.at: New test: expose -export-symbols failure
> when the input consists solely of convenience archives, and
> failure to not export all symbols when the command line length
> is exceeded.
Hrmph. If $archive_expsyms_cmds uses -retain-symbols-file then not
exporting symbols effectively doesn't work. It's anyway a long-term
goal to kill usage of -retain-symbols-file in Libtool on all systems,
but that is something we cannot do right now.
Since it's still useful to run the test even with partial functionality,
but also it's helpful to be able to disambiguate it from full success,
I'm applying this patch to avoid the failing command, but output a SKIP
at the end of the test if it succeeded that far.
Cheers,
Ralf
2007-02-12 Ralf Wildenhues <address@hidden>
* tests/export.at: Exporting is not fully functional with
-retain-symbols-file. Do not test for failure to link `broken'
in this case. At the end of the test, SKIP if we are not fully
functional.
Index: tests/export.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/export.at,v
retrieving revision 1.1
diff -u -r1.1 export.at
--- tests/export.at 11 Feb 2007 16:47:53 -0000 1.1
+++ tests/export.at 12 Feb 2007 20:50:05 -0000
@@ -24,7 +24,10 @@
AT_CHECK([$LIBTOOL --features | grep 'disable shared libraries' && (exit 77)],
[1], [ignore])
AT_CHECK([eval `$LIBTOOL --config | sed -n '/^archive_expsym_cmds=/,/^$/p'`
- test -n "$archive_expsym_cmds" || echo false >can-hide])
+ test -n "$archive_expsym_cmds" || echo false >can-hide
+ case $archive_expsym_cmds in
+ *-retain-symbols-file*) echo false >can-hide ;;
+ esac])
can_hide=:
test -s can-hide && can_hide=false
@@ -161,4 +164,6 @@
fi
done
+AT_CHECK([$can_hide || (exit 77)])
+
AT_CLEANUP