Re: Avoid compiler warnings

[Eric Blake]

Eric Blake <ebb9 <at> byu.net> writes:

> 
> I tried configuring m4 with its --enable-debug switch, which enables
> various -W  warning options, and combined it with -Werror to forcefully
> see the warnings.

A followon - using LTDL_SET_PRELOADED_SYMBOLS() choked with -Wnested-externs.

2006-08-11  Eric Blake  <address@hidden>

        * libltdl/ltdl.h (lt_preloaded_symbols): Declare outside of a
        nested scope.

Index: libltdl/ltdl.h
===================================================================
RCS file: /sources/libtool/libtool/libltdl/ltdl.h,v
retrieving revision 1.83
diff -u -r1.83 ltdl.h
--- libltdl/ltdl.h      25 Nov 2005 18:42:28 -0000      1.83
+++ libltdl/ltdl.h      11 Aug 2006 16:54:11 -0000
@@ -1,5 +1,5 @@
 /* ltdl.h -- generic dlopen functions
-   Copyright (C) 1998-2000, 2004, 2005 Free Software Foundation, Inc.
+   Copyright (C) 1998-2000, 2004, 2005, 2006 Free Software Foundation, Inc.
    Originally by Thomas Tanner <address@hidden>
 
    NOTE: The canonical source of this file is maintained with the
@@ -95,9 +95,9 @@
 
 #define lt_preloaded_symbols   lt__PROGRAM__LTX_preloaded_symbols
 #define LTDL_SET_PRELOADED_SYMBOLS()                   LT_STMT_START{  \
-       extern const lt_dlsymlist lt_preloaded_symbols[];               \
        lt_dlpreload_default(lt_preloaded_symbols);                     \
                                                        }LT_STMT_END
+extern const lt_dlsymlist lt_preloaded_symbols[];