Re: Support -library=stlport4 with Sun C++ compiler

[Albert Chin]

On Thu, Aug 03, 2006 at 02:50:31PM +0200, Ralf Menzel wrote:
> Albert Chin <address@hidden> writes:
> > Good catch. Updated patch attached.
> >
> > 2006-08-01  Albert Chin <address@hidden>
> >
> >     * libtool.m4 (AC_LIBTOOL_POSTDEP_PREDEP) [ solaris ]:
> >     Don't set $postdeps to "-lCstd -lCrun" if
> >     "-library=stlport4" set in CXXFLAGS as stlport4 C++
> >     library incompatible with Cstd C++ library. Use
> >     '-library=Cstd -library=Crun' instead of '-lCstd -lCrun'.
> >
> > 2006-08-01  Albert Chin <address@hidden>
> >
> >     * libltdl/m4/libtool.m4 (_LT_SYS_HIDDEN_LIBDEPS) [ solaris ]:
> >     Don't set $postdeps to "-lCstd -lCrun" if
> >     "-library=stlport4" set in CXXFLAGS as stlport4 C++
> >     library incompatible with Cstd C++ library. Use
> >     '-library=Cstd -library=Crun' instead of '-lCstd -lCrun'.
> 
> I found some problems with the patches:
> 
> 1. In the patch for libtool-HEAD the 'for ... do' line is superflous.
> 
> 2. _LT_AC_TAGVAR doesn't seem to work with libtool-HEAD. I used
>    _LT_TAGVAR, which seems to work.
> 
> 3. In libtool-HEAD the patch addresses the Sun C compiler for Linux
>    and not for Solaris, while the patch for libtool-1-5 addresses the
>    Solaris compiler and ignores the linux version.
> 
> The following patches seem to work for me:

Good catch. I should have tested the new patches! Updated patches
attached.

2006-08-03  Albert Chin <address@hidden>

        * libltdl/m4/libtool.m4 (_LT_SYS_HIDDEN_LIBDEPS) [ linux,
        solaris ]: Remove unterminated for loop from last patch;
        change variable name from $solaris_use_stlport4 to
        $suncpp_use_stlport4 as Sun C++ on GNU/Linux might need
        this feature as well; add -library=stlport4 to solaris
        section as well.

2006-08-03  Albert Chin <address@hidden>

        * libtool.m4 (AC_LIBTOOL_POSTDEP_PREDEP) [ linux,
        solaris ]: Change variable name from $solaris_use_stlport4
        to $suncpp_use_stlport4 as Sun C++ on GNU/Linux might need
        this feature as well; add -library=stlport4 to linux section
        as well.

-- 
albert chin (address@hidden)

1.5
Description: branch-1-5 patch

head
Description: HEAD patch