libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: branch-1-5 UnixWare fixes


From: Ralf Wildenhues
Subject: Re: branch-1-5 UnixWare fixes
Date: Sat, 12 Nov 2005 17:25:01 +0100
User-agent: Mutt/1.5.9i

Hi Tim,

Quite some time ago:

* Tim Rice wrote on Mon, Sep 26, 2005 at 08:41:21PM CEST:
> On Mon, 26 Sep 2005, Ralf Wildenhues wrote:
> : * Tim Rice wrote on Sun, Sep 25, 2005 at 10:05:21PM CEST:
> [snip]
> : > I re-ran the tests using ksh88 and all tests passed.
> : > Must be a ksh bug.
> : > Version M-11/16/88h               passes quote test
> : > Version M-12/28/93e-SCO           fails quote test

> :   make check TESTS=quote.test VERBOSE=x

> = trying: \\ quoting
> = failed: mkdir .libs
>  cc -c "-DVAR=\\test\\" foo.c  -KPIC -DPIC -o .libs/foo.o
>  cc -c "-DVAR=\\test\\" foo.c -o foo.o >/dev/null 2>&1
> = trying: \" quoting
*snip*
> FAIL: quote.test

Does the test pass even with ksh88, after this patch is applied
(CVS HEAD)?

Thank you,
Ralf

        * tests/quote.test: Do not fail on harmless shell bug present
        in some ksh88 versions.
        Reported by Tim Rice <address@hidden> and others.

Index: tests/quote.test
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/quote.test,v
retrieving revision 1.19
diff -u -r1.19 quote.test
--- tests/quote.test    22 Apr 2005 10:10:30 -0000      1.19
+++ tests/quote.test    12 Nov 2005 16:23:46 -0000
@@ -97,9 +97,13 @@
     $ECHO "= trying: \\$mchar quoting"
     result=`$LIBTOOL -n --mode=$mode $preargs 
${preflag}"${flag}${mchar}test${mchar}" $postargs` || status=$EXIT_FAILURE
     match="${match_preflag}${flag}\\${mchar}test\\${mchar} "
+    alt_match="${match_preflag}\"${flag}\\${mchar}test\\${mchar}\" "
     case "$result" in
     *"$match"*)
       $ECHO "= passed: $result"
+      ;;
+    *"$alt_match"*)
+      $ECHO "= passed (harmless sh bug): $result"
       ;;
     *)
       $ECHO "= failed: $result"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]