FYI: libtool bug: freebsd -rpath, LD_LIBRARY_PATH issues

[Ralf Wildenhues]

* Ralf Wildenhues wrote on Fri, Nov 11, 2005 at 12:20:20AM CET:
>
> OK, this PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=28191

> suggests that the change (to give LD_LIBRARY_PATH highest precedence)
> was in version 4.6 (which came out June 2002).  Can anybody confirm
> this?

http://www.freebsd.org/cgi/cvsweb.cgi/src/libexec/rtld-elf/rtld.c does.
I am, by the way, usually amazed how easy it is with the BSDs to get
reliable information from their CVS repos.  They've been very good at
keeping their tree structure stable, I just need to get used to their
way in order to be able to find something.

> Also, I don't know when they stopped using freebsdelf as a name,
> so I'm just guessing from version 4 maybe?

Oh well, the patch tries both anyway, so we needn't worry.

> Dave, could you try this patch on CVS branch-1-5 Libtool?

Dave confirmed this to work (thanks!).  Applied to branch-1-5 and HEAD
(see below).

Cheers,
Ralf


        * libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER) [ freebsd ]:
        Fix shlibpath_overrides_runpath settings.
        Reported by Dave Benson <address@hidden>.

Index: libltdl/m4/libtool.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/m4/libtool.m4,v
retrieving revision 1.40
diff -u -r1.40 libtool.m4
--- libltdl/m4/libtool.m4       10 Nov 2005 18:29:03 -0000      1.40
+++ libltdl/m4/libtool.m4       11 Nov 2005 22:01:31 -0000
@@ -2139,8 +2139,13 @@
     shlibpath_overrides_runpath=yes
     hardcode_into_libs=yes
     ;;
-  *) # from 3.2 on
+  freebsd3.[[2-9]]* | freebsdelf3.[[2-9]]* | \
+  freebsd4.[[0-5]] | freebsdelf4.[[0-5]] | freebsd4.1.1 | freebsdelf4.1.1)
     shlibpath_overrides_runpath=no
+    hardcode_into_libs=yes
+    ;;
+  freebsd*) # from 4.6 on
+    shlibpath_overrides_runpath=yes
     hardcode_into_libs=yes
     ;;
   esac