libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch 08/19] 292-gary-remove-spurious-quotes.diff Queue


From: Gary V. Vaughan
Subject: Re: [patch 08/19] 292-gary-remove-spurious-quotes.diff Queue
Date: Mon, 10 Oct 2005 15:40:23 +0100
User-agent: Mozilla Thunderbird 1.0 (X11/20050305)

Ralf Wildenhues wrote:
Hi Gary,

* Gary V. Vaughan wrote on Mon, Oct 10, 2005 at 12:26:32PM CEST:

libltdl/m4/ltdl.m4 |    2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

Index: libtool--devo--1.0/ChangeLog
from  Gary V. Vaughan  <address@hidden>
        * libltdl/m4/ltdl.m4 (_LT_ENABLE_INSTALL): Remove bogus extra
        closing brackets.


Yes, please commit right away, and also fix the same bug with
AC_LTDL_ENABLE_INSTALL in branch-1-5.

Will do.  Thanks.

I have a slight feeling of deja-vu, we've fixed something similar
before, but can't find good terms to search for the previous change.
Do you have editor macros which balance m4 quotes for you?

Unfortunately no, or I would have spotted this much sooner.  I found
it because I left off a set of closing bracket in another earlier
macro, and all hell broke loose... I had to resort to a binary search,
by removing chunks of ltdl.m4 to home in on the errant brackets :-(

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]