Re: include_expsyms clobbers user files.

[Peter Ekberg]

On Wed, Sep 28, 2005 at 11:03:49AM +0200, Ralf Wildenhues wrote:
> Hi Peter,
> 
> * Peter Ekberg wrote on Tue, Sep 27, 2005 at 02:13:46PM CEST:
> > * Ralf Wildenhues wrote on Sunday, September 25, 2005 15:10 CEST:
> > > 
> > > That's just because you try to avoid any extra copy, which requires
> > > quite some logic, as seen in your proposed patch.
> > 
> > I you don't mind the extra copy, here's a patch which does that instead.
> 
> Hmm.  The improved simplicity is very appealing.  However, I think the
> *.uexp file should be removed after linking (see $delfiles).

Fixed in this patch, I also cleaned up the temporary files used to
filter the dll symbols.

> (The fact that we don't fail on write errors is of course an issue in 
> both cases; lets worry about this later, not now.)
> 
> Also, you should make this conditional on nonempty $include_expsyms;
> no need to punish all users here.

Right...

> > > > Ok, here's a patch. I renamed the orig_export_symbols variable
> > > > as it's now not always the original export_symbols value...
> > > 
> > > I tried hard to find an error in the patch, but failed.
> > > Please install, I think it's ok.
> > 
> > Yes, I tested thoroughly, it was a mess.
> 
> I'm sorry.

No problem, a mess/maze once in a while can be fun.

> >     * libltdl/config/ltmain.m4sh (func_mode_link): Don't modify
> >     user provided symbols file.
> 
> Well, which approach do you like better?  I'd have a slight preference
> for this one, but don't care too much.

I can certainly live without the entangled maze that was the first attempt.

        * libltdl/config/ltmain.m4sh (func_mode_link): Don't modify
        user provided symbols file. Adjust removal of temporary files
        and also remove temporary files used during symbols file
        filtering.

Cheers,
Peter

head-leave-export-symbols-file-alone-3.patch
Description: Text document