libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: FYI: fix dumpbin symbol pipe


From: Peter Ekberg
Subject: RE: FYI: fix dumpbin symbol pipe
Date: Fri, 23 Sep 2005 11:27:05 +0200

Ralf Wildenhues wrote on Thursday, September 22, 2005 16:41 CEST:
> Hi Peter,
> 
> * Peter Ekberg wrote on Thu, Sep 22, 2005 at 04:24:16PM CEST:
> > * Ralf Wildenhues wrote on Thursday, September 08, 2005 11:23 CEST:
> > >
> > > This setting of lt_cv_sys_global_symbol_pipe breaks config.cache,
> > > so don't use it.
> > > 
> > > Ha!  An Autoconf bug, present even in CVS! ;-)
> > 
> > Have you reported this bug?
> 
> Erm, I was wrong.  :-/

Happens to all of us :-)

> Dan added multiline *output variable* support to CVS Autoconf, but not
> multiline *cache variable*.  So, in fact, we are misusing 
> caching here;
> it's documented not to allow newlines.  Sorry for not clearing that up
> back then.

No problem, I'm not using caching much (yet) and I don't expect
others are using dumpbin (yet) so...

> Would you like to fix it?  You could either rewrite your 
> first real awk
> script to consist of one line only, or add a helper variable 
> to remember
> to unset lt_cv_sys_global_symbol_pipe after the 
> AC_CACHE_CHECK, I guess.
> (Please don't break caching for everyone else, it's a rather expensive
> check.)
> 
> > Or are the autoconf people tuned in to this station?
> 
> I would've guessed they'd chime in (and correct me ;-).

Here's a patch:

        * libltdl/m4/libtool.m4 (_LT_CMD_GLOBAL_SYMBOLS): Fix awk
        script to be a single line so that the cache variable isn't
        multiline.

Cheers,
Peter

Attachment: head-one-line-dumpbin-symbol-pipe.patch
Description: head-one-line-dumpbin-symbol-pipe.patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]