libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: use --enable-pic [libtool--gary--1.0--patch-32]


From: Gary V. Vaughan
Subject: Re: use --enable-pic [libtool--gary--1.0--patch-32]
Date: Thu, 01 Sep 2005 11:15:26 +0100
User-agent: Mozilla Thunderbird 1.0 (X11/20050305)

Ralf Wildenhues wrote:
* Noah Misch wrote on Tue, Aug 30, 2005 at 07:26:14PM CEST:

On Tue, Aug 30, 2005 at 12:30:35PM +0100, Gary V. Vaughan wrote:

        * libltdl/m4/options.m4 (_LT_WITH_PIC): Renamed...
        (_LT_ENABLE_PIC): ...this.  Adjust all callers.  The configure
        option is now `--enable-pic', since `--with-pic' implies that the
        user wants to compile in an optional external package called pic.
        * doc/libtool.texi: Update documentation to match.

`pic' is not an external package, but it is also not an optional feature.  In
particular, per Standards, `No `--enable' option should *ever* cause one feature
to replace another.'  --enable-pic effectively disables creation of the non-pic
`.a' library and creates a PIC `.a' library.

I suggest leaving things as they are or dropping the option entirely.  There has
been little mention of this option in the ChangeLog since 1999, when Thomas
Tanner added the feature.  The mail archives on lists.gnu.org do not go back
that far; what was the use case for this feature?  I cannot think of one.


FWIW, I would be OK with this.

Gary, what do you think about just changing the thinko in the
documentation and leaving the rest as-is?

Yep, works for me.  I went back and forth myself over --enable-pic vs.
--with-pic.  Neither is right really, and I wanted to see what everyone
else thought.

I'll commit the doc part of the patch presently.

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]