libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: loop in libtool m4 macros


From: Ralf Wildenhues
Subject: FYI: loop in libtool m4 macros
Date: Mon, 27 Jun 2005 12:08:18 +0200
User-agent: Mutt/1.4.1i

* Ralf Wildenhues wrote on Wed, Jun 22, 2005 at 06:45:35PM CEST:
> 
> > > > 3)
> > > > m4/ltoptions.m4
> > > > >  m4_define([_LT_SET_OPTIONS],
> > > > > -[AC_FOREACH([_LT_Option], [$1], [...]
> > > > > +[m4_if([$1], [], [],
> > > > > +       [AC_FOREACH([_LT_Option], [$1], [...]
> > > > 
> > > > This change is a workaround for a bug I introduced.
> > > > Please remove the workaround, as the bug is now fixed in the Autoconf 
> > > > CVS.
> > > 
> > > When was the bug introduced?  If only with the m4_cdr change, then OK.
> > 
> > Yes, the bug was introduced when I fixed m4_cdr and forgot to fix m4_strip.
> > So the bug lived only for very short in the CVS version.
> 
> Thank you.  I will remove this patch then.

Applied to HEAD and branch-2-0.  (Only this part, so far.)

Regards,
Ralf

> Index: m4/ltoptions.m4
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/m4/ltoptions.m4,v
> retrieving revision 1.11
> diff -u -r1.11 ltoptions.m4
> --- m4/ltoptions.m4   11 Jun 2005 11:11:45 -0000      1.11
> +++ m4/ltoptions.m4   22 Jun 2005 13:44:05 -0000
> @@ -51,14 +51,12 @@
>  # dispatch to that macro; otherwise complain about the unknown option
>  # and exit.
>  m4_define([_LT_SET_OPTIONS],
> -[m4_if([$1], [], [],
> -       [AC_FOREACH([_LT_Option], [$1],
> -                [_LT_SET_OPTION(_LT_Option)
> -                     m4_ifdef(_LT_MANGLE_DEFUN(_LT_Option),
> -                              _LT_MANGLE_DEFUN(_LT_Option),
> -             [m4_fatal([Unknown option `]_LT_Option[' to 
> LT][_INIT_LIBTOOL])])
> -                ])dnl
> -       ])
> +[AC_FOREACH([_LT_Option], [$1],
> +    [_LT_SET_OPTION(_LT_Option)
> +    m4_ifdef(_LT_MANGLE_DEFUN(_LT_Option),
> +          _LT_MANGLE_DEFUN(_LT_Option),
> +     [m4_fatal([Unknown option `]_LT_Option[' to LT][_INIT_LIBTOOL])])
> +    ])dnl
>  dnl
>  dnl Simply set some default values (i.e off) if boolean options were not
>  dnl specified:




reply via email to

[Prev in Thread] Current Thread [Next in Thread]