libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix libtoolize serial comparisons [libtool--gary--1.0--patch-12]


From: Ralf Wildenhues
Subject: Re: fix libtoolize serial comparisons [libtool--gary--1.0--patch-12]
Date: Thu, 31 Mar 2005 18:07:50 +0200
User-agent: Mutt/1.4.1i

* Gary V. Vaughan wrote on Tue, Mar 29, 2005 at 09:33:35PM CEST:
> 
> Patch against HEAD -- actually against my dev branch which already has
> - --patch-11 applied, so this patch may not apply cleanly directly to
> HEAD (sans --patch-11).
> 
> Okay to commit and backport to branch-2-0?
> 
>       Fix problems with serial comparison sed scripts, and factor out
>       common code from similar serial comparison functions:
> 
>       * libtoolize.m4sh (func_keyword_update): Common code factored out
>       of func_ltmain_update and func_config_update.
>       (func_ltmain_update, func_config_update): Adjust, and fix sed
>       expressions to not use unportable ? modifier.
>       (func_install_update): New serial number based file updater keyed
>       of 'scriptversion' variable in install-sh.  Adjust all callers.

> +func_ltmain_update ()
> +{
> +    $opt_debug
> +    my_sed_ltmain=['/^package_revision='\''*[0-9][1-9.]*'\''*/ {
> +      s,^package_revision='\''*\([0-9.]*\)'\''*[       ]*$,\1,; p;
> +    }; d']
> +

I'm sure there's a reason for the embedded single quotes.  I just can't see it.
There are no quotes in config/ltmain.sh

| package_revision=...

Other than that, please apply.

Regards,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]