Re: libtool-branch-2-0: add strlcat/strlcpy emulation

[Bob Friesenhahn]

On Sun, 12 Dec 2004, Albert Chin wrote:

> On Sun, Dec 12, 2004 at 02:37:28PM -0600, Bob Friesenhahn wrote:
> > The attached patch adds strlcat/strlcpy emulation functions to libtool
> > branch 2.0.  These functions are added to replace dangerous
> > strcat/strncat functions in libltdl.  They are not actually used yet.
> >
> > Assuming that this is ok to commit, I will prepare a similar patch for
> > HEAD.
> >
> > Ok to commit?
>
> I'd rather use the OpenBSD versions of these functions. Theirs has
> probably undergone more extensive testing.

Are you suggesting that we slap the FSF license on OpenBSD code? 
That is not something we are allowed to do unless all substantial 
authors file copyright assignment paperwork with the FSF.  Do you see 
a bug in my implementation?

> However, is this really needed? Nothing wrong with strcat/strncat if
> you know how to use it right. No strong objections though.

We have noticed issues with libltdl strcpy/strcat/strncat usage in the 
past so the thought is that using safer functions in the first place 
will minimize the opportunity for bugs.  This was discussed among the 
libtool maintainers and the consensus was that I should add these 
functions.

Bob
======================================
Bob Friesenhahn
address@hidden
http://www.simplesystems.org/users/bfriesen