[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
The dlloader bug (was: make libltdl work on platforms without loader)
From: |
Ralf Wildenhues |
Subject: |
The dlloader bug (was: make libltdl work on platforms without loader) |
Date: |
Sun, 28 Nov 2004 22:52:41 +0100 |
User-agent: |
Mutt/1.5.6+20040722i |
* Gary V. Vaughan wrote on Sun, Nov 28, 2004 at 10:04:44PM CET:
> Ralf Wildenhues wrote:
> >* Gary V. Vaughan wrote on Sun, Nov 28, 2004 at 01:31:52PM CET:
> >>
> >> I expect we'll need to fix the annoying need-a-.la-file-even-to-dlopen-
> >> a-preloaded-module bug too :-(
> >
> >Do you mean the issue that currently prevents libdlloader.la from
> >being convenience-only? Haven't looked yet, but might soon.
>
> Yip.
I don't get it with this bug. If I use the patch at the end of this
mail, my testsuite still passes (albeit, tested linux only).
How can I expose it?
> >Back to above (rightfully) rejected patch. This one seems to do
> >the trick. Not beautiful, but much shorter. OK to apply? Does
> >HAVE_NO_DLLOADER constitute disallowed infringement on autoconf
> >namespace?
>
> No that's fine wrt namespace. It seems odd to say #ifndef HAVE_NO_FOO
> when #ifdef HAVE_FOO is more idiomatic though...
Yeah, guess it's too late already. Will make your proposed changes and
apply sometime this week..
Regards,
Ralf
* libltdl/Makefile.am: install libdlloader only if CONVENIENCE_LTDL.
Index: libltdl/Makefile.am
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/Makefile.am,v
retrieving revision 1.64.2.4
diff -u -r1.64.2.4 Makefile.am
--- libltdl/Makefile.am 23 Nov 2004 16:01:31 -0000 1.64.2.4
+++ libltdl/Makefile.am 28 Nov 2004 21:33:41 -0000
@@ -33,7 +33,6 @@
pkgincludedir = $(includedir)/libltdl
-lib_LTLIBRARIES = libdlloader.la
libdlloader_la_SOURCES = libltdl/lt_error.h lt_error.c \
libltdl/lt__private.h libltdl/lt_system.h \
libltdl/lt__alloc.h lt__alloc.c \
@@ -48,11 +47,11 @@
include_HEADERS = ltdl.h
pkginclude_HEADERS = libltdl/lt_system.h libltdl/lt_error.h \
libltdl/lt_dlloader.h
-lib_LTLIBRARIES += libltdl.la
+lib_LTLIBRARIES = libdlloader.la libltdl.la
endif
if CONVENIENCE_LTDL
-noinst_LTLIBRARIES = libltdlc.la
+noinst_LTLIBRARIES = libdlloader.la libltdlc.la
endif
libltdl_la_SOURCES = ltdl.h ltdl.c \