[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Factor out .la validity checks
From: |
Gary V. Vaughan |
Subject: |
Re: Factor out .la validity checks |
Date: |
Sun, 24 Oct 2004 17:36:00 +0100 |
User-agent: |
Mozilla Thunderbird 0.8 (Macintosh/20040913) |
Noah Misch wrote:
This patch (against HEAD) factors out a common sanity check for the validity of
a .la file. The check varied slightly throughout ltmain.m4sh, and it regularly
failed to quote the file name. This also eliminates a sub-shell, which might
speed things up on some platforms. Comments and test results appreciated.
Looks good to me!
2004-10-22 Noah Misch <address@hidden>
* config/ltmain.m4sh (func_lalib_p, func_ltwrapper_p): New
functions that abstract .la sanity checking.
(func_mode_execute, func_mode_install, func_mode_link,
func_mode_uninstall): Use them.
Thanks, applied with a few small changes... mainly that I've moved the
new functions to after the arg parse loop so that --version/--help etc
will be as fast as possible. Also, with the subshell removed, error
messages from $SED were not captured, so I added a 2>/dev/null at the
appropriate juncture. Have a look at libtool--devo--1.0--patch-279.
Cheers,
Gary.
--
Gary V. Vaughan ())_. address@hidden,gnu.org}
Research Scientist ( '/ http://tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/libtool
Technical Author `(_~)_ http://sources.redhat.com/autobook
signature.asc
Description: OpenPGP digital signature