Re: subdir-object compatibility Autotests [libtool--devo--1.0--patch-260]

[Gary V. Vaughan]

Noah Misch wrote:
> Gary,
>
>
> > +# Hook the test suite into the check rule
> > +check-local: tests/atconfig $(TESTSUITE)
> > +       $(SHELL) $(srcdir)/$(TESTSUITE)
> > +
>
>
> I like ``$(SHELL) $(srcdir)/$(TESTSUITE) $(TESTSUITE_FLAGS)'' to make it easier
> for the user to pass options to the test suite.  Please consider it.
>
>
> > +# Run the test suite on the *installed* tree.
> > +installcheck-local:
> > +       $(SHELL) $(srcdir)/$(TESTSUITE) AUTOTEST_PATH=$(exec_prefix)/bin
>
>
> Likewise.

Good call.  Okay.  I should also pass in the TESTS_ENVIRONMENT:

 $(TESTS_ENVIRONMENT) $(SHELL) $(srcdir)/$(TESTSUITE) $(TESTSUITE_FLAGS)

:-)


> > +# AT_BOOTSTRAP
> > +# ------------
> > +m4_define([AT_BOOTSTRAP],
> > +[[LIBTOOLIZE=${abs_top_builddir}/libtoolize
> > +export LIBTOOLIZE
> > +
> > +test -f ./ltmain.sh || $LIBTOOLIZE --copy
> > +test -f ./configure || autoreconf --force --verbose --install
> > +test -f ./configure || exit 1
> > +./configure
> > +${MAKE-make}
> > +]])
>
>
> This framework uses the user's installations of Autoconf and Automake to
> bootstrap the tests, so the test suite will actually test libtool's behavior on
> platform-acversion-amversion tuples.  Is that intentional?  I kind of like that,
> since the suite will test the collection of tools the user will actually employ.

Yes, it will give us much better testing.  Autotest also captures the 
versions of the other tools it relys on into testsuite.log.  There is no 
need to make a separate VERBOSE=yes run of failed tests, since most of 
the information is already saved to testsuite.log.  By 2.2, I'd like to 
have a libtoolbug script that automatically sends all this useful 
information to the list along with the reporter's bug recipe.

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature