libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libtool--release--2.0 test results


From: Charles Wilson
Subject: Re: libtool--release--2.0 test results
Date: Fri, 08 Oct 2004 01:06:47 -0400
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040616 MultiZilla/1.6.4.0b

Yep, that fixes the quote test failure on cygwin. Whether it's the correct fix, I dunno; I'm not sure what effect this has on other platforms.

--
Chuck


Noah Misch wrote:

On Wed, Oct 06, 2004 at 04:00:58AM -0400, Charles Wilson wrote:

Gary V. Vaughan wrote:

hppa2.0w-hp-hpux11.11: All 87 tests passed (12 tests were not run)
hppa2.0w-hp-hpux11.00: All 87 tests passed (12 tests were not run)
hppa2.0-hp-hpux10.20:  3 of 85 tests failed [[All tagdemo-make]]
mips-sgi-irix6.5: 4 of 99 tests failed [[quote, *-hardcode && *-relink]]

i686-pc-cygwin: 3 of 107 tests failed (1 test was not run)
This is with automake-1.9.1, using branch-2-0

Got same results with CVS HEAD, btw.

The three failed tests were
 quote


Would this patch fix your quote.test failures?  It looks like the --mode=link
tests fail under Cygwin because libtool changes ``-o hell'' to ``-o hell.exe''.

2004-10-06  Noah Misch  <address@hidden>

        * tests/quote.test: Do not look for $preargs in the output,
        because libtool may change them.

--- tests/quote.test~   Wed Oct  6 22:22:11 2004
+++ tests/quote.test    Wed Oct  6 22:37:35 2004
@@ -65,7 +65,10 @@ for mode in compile link install; do
   # We used to have the contents of $match in the case statement,
   # without an intermediate variable, but it would fail on at least
   # Solaris' and HP-UX's /bin/sh.  Ugh!
-  match="$preargs ${preflag}${flag}test "
+  # We must not attempt to match $preargs in the output, because libtool
+  # may modify them.  For example, on Cygwin, ``libtool --mode=link gcc -o
+  # foo foo.o''  becomes ``gcc -o foo.exe foo.o''.
+  match="${preflag}${flag}test "
   case "$result" in
   *"$match"*)
     $ECHO "= passed: $result"
@@ -80,7 +83,7 @@ for mode in compile link install; do
   for mchar in \\ \" \` \$; do
     $ECHO "= trying: \\$mchar quoting"
     result=`$LIBTOOL -n --mode=$mode $preargs 
${preflag}"${flag}${mchar}test${mchar}" $postargs` || status=$EXIT_FAILURE
-    match="$preargs ${preflag}${flag}\\${mchar}test\\${mchar} "
+    match="${preflag}${flag}\\${mchar}test\\${mchar} "
     case "$result" in
     *"$match"*)
       $ECHO "= passed: $result"
@@ -98,7 +101,7 @@ for mode in compile link install; do
$ECHO "= trying: \"$mchar\" quoting"
     result=`$LIBTOOL -n --mode=$mode $preargs 
${preflag}"${flag}${mchar}test${mchar}" $postargs` || status=$EXIT_FAILURE
-    match="$preargs ${preflag}\"${flag}${mchar}test${mchar}\" "
+    match="${preflag}\"${flag}${mchar}test${mchar}\" "
     case "$result" in
     *"$match"*)
       $ECHO "= passed: $result"







reply via email to

[Prev in Thread] Current Thread [Next in Thread]